hoshinojyunn commented on code in PR #64652:
URL: https://github.com/apache/doris/pull/64652#discussion_r3450377642
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -2707,9 +2707,11 @@ private boolean createOlapTable(Database db,
CreateTableInfo createTableInfo) th
}
bfFpp = PropertyAnalyzer.analyzeBloomFilterFpp(properties);
- if (bfColumns != null && bfFpp == 0) {
+ boolean hasLegacyBf = bfColumns != null;
+ boolean hasNamedBf =
!Index.extractBloomFilterColumns(createTableInfo.getIndexes()).isEmpty();
Review Comment:
Reasonable. Named-only BLOOMFILTER tables should also make bfFpp part of the
table signature.
Changed:
- Updated OlapTable.getSignature(...) to use getCopiedBfColumns() instead of
the legacy-only member field
- Added OlapTableTest.testNamedBloomFilterFppAffectsSignature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
