hoshinojyunn commented on code in PR #64652:
URL: https://github.com/apache/doris/pull/64652#discussion_r3450379883
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/IndexDefinition.java:
##########
@@ -231,6 +235,12 @@ public void checkColumn(ColumnDefinition column, KeysType
keysType,
} catch (Exception ex) {
throw new AnalysisException("invalid ngram bf index
params:" + ex.getMessage(), ex);
}
+ } else if (indexType == IndexType.BLOOMFILTER) {
Review Comment:
Reasonable. BLOOMFILTER should not inherit the inverted-index-only VARIANT +
V1/DEFAULT rejection.
Changed:
- Narrowed the VARIANT + V1/DEFAULT restriction in both
IndexDefinition.checkColumn(...) overloads so it does not apply to BLOOMFILTER
- Kept NGRAM_BF behavior unchanged
- Added VARIANT + BLOOMFILTER + V1/DEFAULT coverage for both overloads
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
