eldenmoon commented on code in PR #66858:
URL: https://github.com/apache/doris/pull/66858#discussion_r3900155976
##########
be/src/core/value/variant/variant_field.h:
##########
@@ -53,9 +53,7 @@ class VariantField {
VariantField& operator=(const VariantField& other);
VariantField& operator=(VariantField&& other) noexcept;
- // Transitional V1 Field representation. V1 callers keep their existing
map semantics while
- // V2 owns one encoded row; once ColumnVariant is removed, this
constructor and accessors can
- // be deleted without changing the V2 representation.
+ // Transitional field-map representation kept only for Field API callers.
VariantField(VariantMap legacy);
bool is_legacy() const noexcept;
Review Comment:
这个 legacy 是不是可以删了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
