eldenmoon commented on code in PR #66858:
URL: https://github.com/apache/doris/pull/66858#discussion_r3900415443
##########
be/src/storage/segment/variant/variant_column_reader.cpp:
##########
@@ -498,13 +498,10 @@ Status VariantColumnReader::_build_read_plan_flat_leaves(
}
if (relative_path.empty()) {
- // root path, use VariantRootColumnIterator
- // ROOT_FLAT is the legacy ColumnVariant compaction/checksum path.
- // TODO: Remove it together with legacy ColumnVariant readers.
- DORIS_CHECK(!target_col.variant_is_v2());
- plan->kind = ReadKind::ROOT_FLAT;
+ plan->kind = ReadKind::HIERARCHICAL;
Review Comment:
> // ROOT_FLAT reads the persisted root column itself. It does not rebuild
root `v` from
// regular extracted columns such as `v.keep` / `v.owner`; only the
optional root-merge
// wrapper below may fold NestedGroup data back into the root view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
