eldenmoon commented on code in PR #66858:
URL: https://github.com/apache/doris/pull/66858#discussion_r3900198613
##########
be/src/exprs/function/cast/variant_v2/cast_variant_v2.cpp:
##########
@@ -122,6 +123,23 @@ Status execute_to_variant(const DataTypePtr&
captured_from_type, FunctionContext
} else if (primitive == TYPE_ARRAY) {
RETURN_IF_ERROR(cast_array_to_variant(source_ptr, from_type, rows,
forced_nulls(null_map,
rows), &output));
+ } else if (is_string_type(primitive)) {
Review Comment:
这里是错误的，String 不应该解析，这个不是 ColumnVariantV2
的正确行为，评估一下为什么引入，删除是什么行为，应该删除，如果可以删除，形成单独的 commit 来 review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
