mrhhsg commented on PR #68125:
URL: https://github.com/apache/doris/pull/68125#issuecomment-5741618121
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68125
commit: 360150637fe89ce75a12a1328acb59d1cc7987b1
base: af525d567d5352fb8ee2bead6aab3dbc9b23984c
reviewed_at: 2026-09-19T19:51+08:00
reviewer: mrhhsg
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 1, nit: 1}
rounds: 1
converged: true
```
**Notes for maintainers**
- Minor —
`regression-test/suites/point_query_p0/test_point_query_read_time_hidden_columns.groovy:77-80`:
the MINMAX positive SQL case does not enter UNIQUE pushdown: the flag defaults
to false, and hidden-column mode removes the DELETE_SIGN Filter required by the
rule. Enable the true case, add the explicit delete-sign predicate, and assert
`pushAggOp=MINMAX`; this was established statically, not by running SQL.
- Nit — `be/src/storage/segment/segment.cpp:180-188`: update the PR-body
blanket-fallback sentence to reflect that constant-reader-backed COMMIT_TSO
keeps metadata-only MINMAX. VERSION/BINLOG values without that reader support
fall back.
- Static review only: all 13 changed files independently covered; no build,
tests, SQL/EXPLAIN, lint or benchmark executed. Earlier include Nit and the six
known-thread mechanisms were rechecked against this head and are addressed in
code/test shape.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
