github-actions[bot] commented on code in PR #68604: URL: https://github.com/apache/doris/pull/68604#discussion_r4130978434
########## regression-test/suites/arrow_flight_sql_p0/test_flight_int96_timestamp_range.groovy: ########## @@ -0,0 +1,83 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +import java.sql.DriverManager +import java.sql.Types +import java.time.LocalDateTime + +suite("test_flight_int96_timestamp_range", "arrow_flight_sql,external,hive,tvf,external_docker") { + if (!"true".equalsIgnoreCase(context.config.otherConfigs.get("enableHiveTest"))) { + return + } + def host = context.config.otherConfigs.get("externalEnvIp") + def port = context.config.otherConfigs.get("hive2HdfsPort") + // External clusters can override the configured Flight port; use the running FE's endpoint. + def frontend = jdbc_sql_return_maparray("SHOW FRONTENDS").find { + it.IsMaster.toString().toBoolean() && it.Alive.toString().toBoolean() + } + assertNotNull(frontend) + assertTrue(frontend.ArrowFlightSqlPort.toString().toInteger() > 0) + def flightUrl = "jdbc:arrow-flight-sql://${frontend.Host}:${frontend.ArrowFlightSqlPort}" + Review Comment: [P2] Use a runner-reachable Flight endpoint for this suite. `SHOW FRONTENDS.Host` is the FE's advertised host, which can be internal in routed or containerized deployments even when `extArrowFlightSqlHost` reaches the service. The new connection then fails before any INT96 assertions run. The existing Iceberg Flight suite retains the configured host while discovering the live port; please use the same reachable endpoint pattern here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
