HappenLee commented on PR #68672: URL: https://github.com/apache/doris/pull/68672#issuecomment-5976179937
/review Please re-review the updated head `9180e96509b5b7b4816cde183bcc667b5c18326d`, focusing on the remaining virtual-column condition-cache P1. `VirtualSlotRef::get_digest()` now returns the existing zero-digest sentinel. Verify its propagation through parent expressions, scan conjuncts and scanner refresh, and that zero disables both cache lookup and insertion. Ordinary deterministic predicates retain the existing positive cache-hit regression. Added BE unit coverage and a regression with two different deterministic virtual-column definitions. EXPLAIN checks ensure CSE actually produces virtual slots. The final regression reproduced missing row `k=9999` on the existing pre-fix ASAN BE when the second query followed the first; uncached reference queries return the correct result. The original review's redundant AND comparisons are simplified away, so the regression uses repeated addition instead. Validation: clang-format/check-format 16.0.6, header hygiene, git diff --check, and clang-tidy for the changed header and unit-test translation unit passed. `run-be-ut.sh --run -j 48 --filter=VirtualSlotRefTest.ConditionCacheDigest*` is blocked before compilation by missing `thirdparty/installed/lib64/libpaimon_c.a`. The new BE was not built, so post-fix runtime validation remains pending CI. Please assess the fix with that explicit limitation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
