CalvinKirs commented on PR #68923:
URL: https://github.com/apache/doris/pull/68923#issuecomment-6119402660
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68923
commit: 597169ba629d3d3054828778380cc47ee4e904dd
base: 84e5e6cd52b05ccbbe9a8482d1878a13f3924a20
reviewed_at: 2026-10-12T15:03+08:00
reviewer: CalvinKirs
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 2
converged: true
```
**Notes for maintainers**
- Independent full review at `gpt-6.1-sol` / `xhigh` covers all 36 changed
files. The prior grants column offsets and SHOW CREATE snapshot findings are
fixed at this head.
- `fe/fe-authentication/fe-authentication-spi/README.md:204-213` — Accepted
rollback limitation: preserve legacy JIT/chain/certificate semantics. The
undisclosed local password hash protects the original account's built-in
password login; old binaries do not enforce the new binding against every
external path or same-name temporary identity. No metadata-version barrier is
required.
- Before review, author validation passed FE build/Checkstyle, 96 unit
tests, two regression suites and 300 ALTER plus 300 SHOW operations in
concurrent MySQL sessions. Full manager P0 and an actual old-binary rollback
were not run.
<sub>Reviewed locally with the `doris-repo-review` pipeline (a local port of
`.github/workflows/code-review-runner.yml`). This is not a CI status
check.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
