CalvinKirs commented on PR #68923:
URL: https://github.com/apache/doris/pull/68923#issuecomment-6122131299
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68923
commit: af2faebba0406c6fd805ec6703f3adf8b38dfa0a
base: 84e5e6cd52b05ccbbe9a8482d1878a13f3924a20
reviewed_at: 2026-10-12T18:09+08:00
reviewer: CalvinKirs
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 2
converged: true
```
**Notes for maintainers**
- All 36 changed paths and all 16 critical checkpoints are covered. Fresh
real integration-manager fixtures preserve actual Auth execution; SHOW GRANTS
consumers match the added column, including Cloud cluster/compute offsets 12/16.
- `fe/fe-authentication/fe-authentication-spi/README.md:204-217` — rollback
keeps an undisclosed random local password hash. Legacy
external/JIT/chain/certificate behavior and old live domain-alias hashes until
successful resolver refresh are accepted existing semantics. Older checkpoints
can discard bindings; save and reapply binding DDL after re-upgrade.
- Author validation before review: 30 tests/four classes passed at this
head; the preceding unchanged-production head e02c2df passed 105 tests/15
classes and two regression suites. No builds/tests were rerun during review.
Actual old FE binaries, custom certificate-provider deployment and full manager
P0 remain unverified.
<sub>Reviewed locally with the `doris-repo-review` pipeline (a local port of
`.github/workflows/code-review-runner.yml`). This is not a CI status
check.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
