CalvinKirs commented on PR #68923:
URL: https://github.com/apache/doris/pull/68923#issuecomment-6120373211
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68923
commit: e02c2df735361c99a6af3bf91ce817a8f603579a
base: 84e5e6cd52b05ccbbe9a8482d1878a13f3924a20
reviewed_at: 2026-10-12T16:14+08:00
reviewer: CalvinKirs
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- Full independent review performed with `gpt-6.1-sol` / `xhigh` on all 33
changed files. ALTER USER retains its existing single-operation rule; binding
reuses one SET_PASSWORD record. Legacy LDAP code and ordinary manual-lock
storage are restored.
- `fe/fe-authentication/fe-authentication-spi/README.md:204-217` — Accepted
rollback limitation: keep legacy external/JIT/chain/certificate behavior. The
undisclosed local hash protects entries carrying it; old serving domain aliases
can retain a previous hash until their existing resolver successfully refreshes
them. Preserve that legacy propagation behavior. Older checkpoints can discard
bindings; save and reapply their DDL after re-upgrade. No compatibility lock or
metadata-version barrier is introduced.
- Before review, FE build/Checkstyle, 105 unit tests in 15 classes and two
regression suites passed with zero failures/errors/skips. Includes
different-host LDAP/JIT semantics, manual locks, single-operation refusal and
no-plugin replay. Full manager P0 and actual old binaries were not run.
<sub>Reviewed locally with the `doris-repo-review` pipeline (a local port of
`.github/workflows/code-review-runner.yml`). This is not a CI status
check.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
