eldenmoon commented on PR #69995:
URL: https://github.com/apache/doris/pull/69995#issuecomment-6822995656

   <!-- doris-repo-review:v1:begin -->
   ### Local pipeline review — ✅ PASS
   
   ```yaml
   schema: doris-repo-review/v1
   status: PASS
   pr: apache/doris#69995
   commit: 326532285e5b7bd942eef91521ef1c0014ed98fb
   base: 9e598d38789571a7fc30652aa054f035bd4f1184
   reviewed_at: 2026-11-12T16:01+08:00
   reviewer: eldenmoon
   model: gpt-6-astra
   effort: xhigh
   findings: {blocker: 0, major: 0, minor: 0, nit: 0}
   rounds: 1
   converged: true
   ```
   
   **Notes for maintainers**
   
   - The previous F-01 is fixed: both versioned DDL branches preserve the 
source policy through the shared helper (`Env.java:4524`, `Env.java:4880`); 
legacy/default-false output is unchanged.
   - `VariantEscapeTableTest.java:47-86` covers both renderers with true/false 
and recreates catalog tables from emitted DDL, asserting the retained policy 
and snapshot version. Full snapshot-import/SEARCH execution is not covered by 
these tests.
   - Incremental follow-up to b1a24ab: the new head is its direct child; 
whole-tree comparison proves only Env.java and VariantEscapeTableTest.java 
changed. The earlier full review and 17 dismissals were inherited after content 
verification.
   - Static source/test review only; no builds or tests were run locally. 
Exact-head TeamCity compile/feut/beut/cloudut remain pending; this PASS does 
not certify CI completion.
   
   <sub>Reviewed locally with the `doris-repo-review` pipeline. Repository 
policy may accept this receipt for the matching commit; it is not a human 
Apache approval.</sub>
   <!-- doris-repo-review:v1:end -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to