github-actions[bot] commented on code in PR #69995:
URL: https://github.com/apache/doris/pull/69995#discussion_r4562594545
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -4402,6 +4404,13 @@ private static void addOlapTablePropertyInfo(OlapTable
olapTable, StringBuilder
}
}
+ private static void addVariantEscapeDotsInKeysProperty(OlapTable
olapTable, StringBuilder sb) {
+ if (olapTable.getVariantEscapeDotsInKeys()) {
+
sb.append(",\n\"").append(PropertyAnalyzer.PROPERTIES_VARIANT_ESCAPE_DOTS_IN_KEYS)
+ .append("\" = \"true\"");
Review Comment:
[P2] Preserve NestedGroup=false in escaped-table DDL
Create an escaped source whose VARIANT column explicitly sets
`variant_enable_nested_group=false`, then run `SET
default_variant_enable_nested_group=true; CREATE TABLE dst LIKE src`. The
column renderer (`VariantType.toSql()`) omits this false setting, while this
helper emits the true table policy. `CreateTableLikeCommand` reparses that DDL
using the receiving session's true default, and `validateVariantTable` rejects
it with `Escaped tables do not support NestedGroup`. Replaying SHOW CREATE has
the same failure. Preserve explicit false in escaped-table column DDL and cover
a roundtrip under the true session default; the existing roundtrip test forces
that default to false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
