csun5285 commented on code in PR #69995:
URL: https://github.com/apache/doris/pull/69995#discussion_r4558832539
##########
be/src/exec/scan/olap_scanner.cpp:
##########
@@ -634,9 +634,13 @@ Status OlapScanner::_init_read_schema() {
"field name is invalid. field={}, field_name_to_index={},
col_unique_id={}",
slot->col_name(), tablet_schema->get_all_field_names(),
slot->col_unique_id());
}
-
const auto& column = tablet_schema->column(index);
auto* olap_local_state =
static_cast<OlapScanLocalState*>(_local_state);
+ const auto& cast_types = olap_local_state->_cast_types_for_variants;
+ if (auto it = cast_types.find(slot->col_name()); it !=
cast_types.end()) {
Review Comment:
查询路径上可以都不用动，FE escape一下path
##########
be/src/exec/scan/olap_scanner.cpp:
##########
@@ -634,9 +634,13 @@ Status OlapScanner::_init_read_schema() {
"field name is invalid. field={}, field_name_to_index={},
col_unique_id={}",
slot->col_name(), tablet_schema->get_all_field_names(),
slot->col_unique_id());
}
-
const auto& column = tablet_schema->column(index);
auto* olap_local_state =
static_cast<OlapScanLocalState*>(_local_state);
+ const auto& cast_types = olap_local_state->_cast_types_for_variants;
+ if (auto it = cast_types.find(slot->col_name()); it !=
cast_types.end()) {
Review Comment:
如果FE 把Slot 里面的path改写了，be 这些都不动了
##########
be/src/storage/tablet/tablet_schema.h:
##########
@@ -79,6 +79,7 @@ class TabletColumn : public MetadataAdder<TabletColumn> {
int32_t doc_hash_shard_count = 64;
bool enable_nested_group = false;
+ bool escape_dots_in_keys = false;
Review Comment:
这个属性放在 TabletSchema 里面了，还有必要在 TabletColumn 存一份吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
