Gabriel39 commented on code in PR #70693:
URL: https://github.com/apache/doris/pull/70693#discussion_r4604634157


##########
be/src/util/brpc_client_cache.h:
##########
@@ -256,7 +257,11 @@ class BrpcClientCache {
                                                const std::string& 
connection_group = "",
                                                int connect_timeout_ms = 2000, 
int max_retry = 10) {
         brpc::ChannelOptions options;
-        Status status = 
doris::client::configure_brpc_channel_options(&options);
+        // Function endpoints are external services, unlike backend-to-backend 
cluster channels.
+        constexpr auto purpose = std::is_same_v<T, PFunctionService_Stub>
+                                         ? client::RpcPurpose::EXTERNAL_SERVICE
+                                         : client::RpcPurpose::INTERNAL_RPC;
+        Status status = client::configure_brpc_channel_options(&options, 
purpose);

Review Comment:
   Fixed in 78bb92f49840. BRPC transport setup failures now follow the existing 
nullptr acquisition contract instead of throwing Status across worker 
boundaries. No failed stub is cached, and diagnostics stay generic. A real TLS 
BRPC cache test removes the configured certificate/key/CA files or supplies an 
unsupported verification mode; all twelve recreation, fresh-cache and uncached 
acquisition paths threw before the fix. Existing authenticated connections 
remain secure and reusable, and restoring configuration permits RPCs through 
both caches. All 175 ASAN native tests, the full RELEASE BE build, clang-format 
16, header hygiene and scoped clang-tidy pass.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to