github-actions[bot] commented on code in PR #70693:
URL: https://github.com/apache/doris/pull/70693#discussion_r4608400149


##########
fe/fe-core/src/main/java/org/apache/doris/common/OssThriftClientTransportProvider.java:
##########
@@ -26,8 +29,21 @@
 public class OssThriftClientTransportProvider implements 
ThriftClientTransportProvider {
     @Override
     public TTransport createTransport(TNetworkAddress address, int timeoutMs, 
boolean nonBlocking) throws Exception {
-        return nonBlocking
-                ? new TFramedTransport(new TSocket(address.hostname, 
address.port, timeoutMs))
+        TSocket socket = PrivateRpcTls.enabled(Protocol.THRIFT)
+                ? new TlsThriftSocket(address.hostname, address.port, 
timeoutMs)

Review Comment:
   [P2] Keep remote Doris catalogs outside the cluster TLS policy
   
   `FrontendService` clients also reach independent Doris clusters: 
`FeServiceClient.getRemoteFeClient()` borrows `ClientPool.frontendPool`, which 
retains the default `INTERNAL_RPC` purpose. With local private TLS enabled, a 
supported `type=doris`, `use_arrow_flight=false` catalog pointing to a default 
plaintext remote cluster now sends a TLS handshake to its FE, so 
`getOlapTable()` and remote queries/transactions fail. There is no 
catalog-level Thrift TLS override; `metadata_http_ssl_enabled` only controls 
HTTP, and excluding `thrift` also removes local private TLS. Give 
remote-catalog connections their own endpoint policy/pool and cover them with 
local private TLS enabled. This is distinct from the repaired broker case: the 
external endpoint is a remote Doris FE reached through the still-shared 
frontend pool.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to