Gabriel39 commented on code in PR #70693:
URL: https://github.com/apache/doris/pull/70693#discussion_r4609078227


##########
fe/fe-core/src/main/java/org/apache/doris/common/OssThriftClientTransportProvider.java:
##########
@@ -26,8 +29,21 @@
 public class OssThriftClientTransportProvider implements 
ThriftClientTransportProvider {
     @Override
     public TTransport createTransport(TNetworkAddress address, int timeoutMs, 
boolean nonBlocking) throws Exception {
-        return nonBlocking
-                ? new TFramedTransport(new TSocket(address.hostname, 
address.port, timeoutMs))
+        TSocket socket = PrivateRpcTls.enabled(Protocol.THRIFT)
+                ? new TlsThriftSocket(address.hostname, address.port, 
timeoutMs)

Review Comment:
   Fixed in 68606d280003. Remote FE metadata/transaction calls now use a 
separate external-purpose pool. Worker catalog identity selects an isolated 
remote gRPC proxy for prepare/start, result fetch, cancellation and 
failed-channel eviction; native V1/HTTP/V2 writes and partition callbacks 
retain the same external policy. Warm external clients cannot satisfy internal 
TLS lookups at the same address, and file-key descriptors are rejected before 
serialization to remote plaintext channels. Real-loopback coverage includes 
remote metadata/pool reuse/reopen, remote gRPC cache reuse/recreation, 
BRPC/HTTP/stream opens and remote FE master retry with local private TLS 
enabled. All 63 selected FE tests and 198 ASAN native tests pass; FE 
Checkstyle, native formatting, header hygiene and clang-tidy pass.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to