github-actions[bot] commented on code in PR #70705:
URL: https://github.com/apache/doris/pull/70705#discussion_r4609991911


##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -116,6 +116,12 @@ public class Config extends ConfigBase {
     @ConfField(description = "Whether to enable compression for FE audit log 
files")
     public static boolean audit_log_enable_compress = false;
 
+    @ConfField(mutable = true, callback = RegexConfHandler.class, description 
= "Case-insensitive regex searched in "
+            + "data source property names when masking output. Combined with 
built-in and provider secret rules. "
+            + "Use (?!) to disable only this additional rule. Applies on each 
FE without changing connection values.")
+    public static volatile String datasource_sensitive_property_pattern =

Review Comment:
   [P2] Preserve regex escaping when configuring all FEs
   
   In a multi-FE cluster with default SQL escaping, `ADMIN SET ALL FRONTENDS 
CONFIG ("datasource_sensitive_property_pattern" = "^custom[.]pin\\d+$")` stores 
`^custom[.]pin\d+$` locally, but `Env.setConfig()` forwards 
`getLocalSetStmt()`, which embeds that decoded value into SQL without escaping 
it. Peer parsing drops the remaining backslash and accepts `^custom[.]pind+$`. 
Consequently, a retained `custom.pin1` credential is masked locally but remains 
visible in peer SHOW/audit/lineage output even though the command succeeds. 
Please make this regex survive the supported all-FE configuration route, for 
example by quoting the forwarded SQL literal, and cover 
parse/serialize/reparse; the new tests only call `setMutableConfig()` directly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to