Gabriel39 commented on code in PR #70705:
URL: https://github.com/apache/doris/pull/70705#discussion_r4610238659
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -116,6 +116,12 @@ public class Config extends ConfigBase {
@ConfField(description = "Whether to enable compression for FE audit log
files")
public static boolean audit_log_enable_compress = false;
+ @ConfField(mutable = true, callback = RegexConfHandler.class, description
= "Case-insensitive regex searched in "
+ + "data source property names when masking output. Combined with
built-in and provider secret rules. "
+ + "Use (?!) to disable only this additional rule. Applies on each
FE without changing connection values.")
+ public static volatile String datasource_sensitive_property_pattern =
Review Comment:
Fixed in 839476c8b764b574118be2cfdecd8d4f1f3bcc43. The new regression
reproduces the original SQL parse, local configuration application,
getLocalSetStmt serialization, peer reparse/application and resulting
credential exposure: before the fix, custom.pin1 renders as the raw fixture
value. The serializer now uses the existing SqlLiteralUtils.quoteStringLiteral
codec for both names and values under the forwarded sql_mode. Tests cover
default and NO_BACKSLASH_ESCAPES modes, local/all-FE scope, quotes,
backslashes, control characters and empty strings. Local validation: 367 tests
in 35 selected classes and FE Checkstyle pass. Peer application is simulated
in-process; a real multi-FE RPC/SQL regression was not executed locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]