Gabriel39 commented on PR #70705:
URL: https://github.com/apache/doris/pull/70705#issuecomment-6971924593
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70705
commit: 839476c8b764b574118be2cfdecd8d4f1f3bcc43
base: de48fa225e444ea4f25cf0699a656a901ad1ceb1
reviewed_at: 2026-11-18T15:21+08:00
reviewer: Gabriel39
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/AdminSetFrontendConfigCommand.java:128-131`:
the known all-FE regex escaping issue is fixed by the shared mode-aware
literal codec. The earlier local-only configuration conclusion was reopened and
corrected.
- `fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:1287`
and `fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java:571`:
primary-source review confirms SQL_MODE is forwarded and restored before peer
parsing; supported local, master, proxy and HTTP configuration routes were
checked.
-
`fe/fe-core/src/test/java/org/apache/doris/nereids/trees/plans/commands/AdminSetFrontendConfigCommandTest.java:45-98`:
real parser/serializer/Env/redaction tests cover both escape modes. Peer
application is simulated in-process; actual multi-FE RPC and the SQL audit
regression were not executed locally. Existing author logs report 367 tests
passing; this review ran no tests or builds.
- All 51 changed paths are covered, including verified inheritance for 49
byte-identical files. Round 1 converged with zero accepted findings at every
severity.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]