github-actions[bot] commented on code in PR #17820:
URL: https://github.com/apache/doris/pull/17820#discussion_r1136791535
##########
be/src/olap/rowset/segment_v2/bitmap_index_writer.cpp:
##########
@@ -64,7 +64,7 @@ class BitmapIndexWriterImpl : public BitmapIndexWriter {
using MemoryIndexType = typename
BitmapIndexTraits<CppType>::MemoryIndexType;
explicit BitmapIndexWriterImpl(const TypeInfo* type_info)
- : _type_info(type_info), _reverted_index_size(0), _pool() {}
+ : _type_info(type_info), _reverted_index_size(0), _arena() {}
Review Comment:
warning: initializer for member '_arena' is redundant
[readability-redundant-member-init]
```suggestion
: _type_info(type_info), _reverted_index_size(0), {}
```
##########
be/src/olap/rowset/segment_v2/indexed_column_writer.cpp:
##########
@@ -40,7 +40,7 @@ IndexedColumnWriter::IndexedColumnWriter(const
IndexedColumnWriterOptions& optio
: _options(options),
_type_info(type_info),
_file_writer(file_writer),
- _mem_pool(),
+ _arena(),
Review Comment:
warning: initializer for member '_arena' is redundant
[readability-redundant-member-init]
```suggestion
,
```
##########
be/test/olap/ordered_data_compaction_test.cpp:
##########
@@ -213,15 +213,15 @@
uint32_t num_rows = 0;
for (int i = 0; i < rowset_data.size(); ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rowset_data[i].size(); ++rid) {
uint32_t c1 = std::get<0>(rowset_data[i][rid]);
uint32_t c2 = std::get<1>(rowset_data[i][rid]);
- input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&c2),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&c2),
&arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(1, reinterpret_cast<char*>(&c2),
&arena);
^
```
##########
be/test/olap/ordered_data_compaction_test.cpp:
##########
@@ -213,15 +213,15 @@
uint32_t num_rows = 0;
for (int i = 0; i < rowset_data.size(); ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rowset_data[i].size(); ++rid) {
uint32_t c1 = std::get<0>(rowset_data[i][rid]);
uint32_t c2 = std::get<1>(rowset_data[i][rid]);
- input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&c2),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&c2),
&arena);
if (tablet_schema->keys_type() == UNIQUE_KEYS) {
uint8_t num = 0;
- input_row.set_field_content(2,
reinterpret_cast<char*>(&num), &mem_pool);
+ input_row.set_field_content(2,
reinterpret_cast<char*>(&num), &arena);
}
s = rowset_writer->add_row(input_row);
Review Comment:
warning: no member named 'add_row' in 'doris::RowsetWriter'
[clang-diagnostic-error]
```cpp
s = rowset_writer->add_row(input_row);
^
```
##########
be/test/olap/ordered_data_compaction_test.cpp:
##########
@@ -213,15 +213,15 @@
uint32_t num_rows = 0;
for (int i = 0; i < rowset_data.size(); ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rowset_data[i].size(); ++rid) {
uint32_t c1 = std::get<0>(rowset_data[i][rid]);
uint32_t c2 = std::get<1>(rowset_data[i][rid]);
- input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&c2),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&c2),
&arena);
if (tablet_schema->keys_type() == UNIQUE_KEYS) {
uint8_t num = 0;
- input_row.set_field_content(2,
reinterpret_cast<char*>(&num), &mem_pool);
+ input_row.set_field_content(2,
reinterpret_cast<char*>(&num), &arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(2,
reinterpret_cast<char*>(&num), &arena);
^
```
##########
be/test/olap/row_cursor_test.cpp:
##########
@@ -344,31 +343,31 @@
Slice l_char("well");
int32_t l_int = 10;
- left.set_field_content(0, reinterpret_cast<char*>(&l_char),
_mem_pool.get());
- left.set_field_content(1, reinterpret_cast<char*>(&l_int),
_mem_pool.get());
+ left.set_field_content(0, reinterpret_cast<char*>(&l_char), _arena.get());
+ left.set_field_content(1, reinterpret_cast<char*>(&l_int), _arena.get());
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
left.set_field_content(1, reinterpret_cast<char*>(&l_int), _arena.get());
^
```
##########
be/test/olap/row_cursor_test.cpp:
##########
@@ -344,31 +343,31 @@
Slice l_char("well");
int32_t l_int = 10;
- left.set_field_content(0, reinterpret_cast<char*>(&l_char),
_mem_pool.get());
- left.set_field_content(1, reinterpret_cast<char*>(&l_int),
_mem_pool.get());
+ left.set_field_content(0, reinterpret_cast<char*>(&l_char), _arena.get());
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
left.set_field_content(0, reinterpret_cast<char*>(&l_char),
_arena.get());
^
```
##########
be/test/olap/row_cursor_test.cpp:
##########
@@ -344,31 +343,31 @@
Slice l_char("well");
int32_t l_int = 10;
- left.set_field_content(0, reinterpret_cast<char*>(&l_char),
_mem_pool.get());
- left.set_field_content(1, reinterpret_cast<char*>(&l_int),
_mem_pool.get());
+ left.set_field_content(0, reinterpret_cast<char*>(&l_char), _arena.get());
+ left.set_field_content(1, reinterpret_cast<char*>(&l_int), _arena.get());
RowCursor right_eq;
res = right_eq.init(tablet_schema);
Slice r_char_eq("well");
int32_t r_int_eq = 10;
- right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_mem_pool.get());
- right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_mem_pool.get());
+ right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_arena.get());
+ right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_arena.get());
EXPECT_EQ(compare_row(left, right_eq), 0);
Review Comment:
warning: use of undeclared identifier 'compare_row' [clang-diagnostic-error]
```cpp
EXPECT_EQ(compare_row(left, right_eq), 0);
^
```
##########
be/test/olap/row_cursor_test.cpp:
##########
@@ -344,31 +343,31 @@
Slice l_char("well");
int32_t l_int = 10;
- left.set_field_content(0, reinterpret_cast<char*>(&l_char),
_mem_pool.get());
- left.set_field_content(1, reinterpret_cast<char*>(&l_int),
_mem_pool.get());
+ left.set_field_content(0, reinterpret_cast<char*>(&l_char), _arena.get());
+ left.set_field_content(1, reinterpret_cast<char*>(&l_int), _arena.get());
RowCursor right_eq;
res = right_eq.init(tablet_schema);
Slice r_char_eq("well");
int32_t r_int_eq = 10;
- right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_mem_pool.get());
- right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_mem_pool.get());
+ right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_arena.get());
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_arena.get());
^
```
##########
be/test/olap/ordered_data_compaction_test.cpp:
##########
@@ -213,15 +213,15 @@ class OrderedDataCompactionTest : public ::testing::Test {
uint32_t num_rows = 0;
for (int i = 0; i < rowset_data.size(); ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rowset_data[i].size(); ++rid) {
uint32_t c1 = std::get<0>(rowset_data[i][rid]);
uint32_t c2 = std::get<1>(rowset_data[i][rid]);
- input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&c2),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&arena);
^
```
##########
be/src/olap/rowset/segment_v2/bloom_filter_index_writer.cpp:
##########
@@ -69,7 +68,7 @@ class BloomFilterIndexWriterImpl : public
BloomFilterIndexWriter {
const TypeInfo* type_info)
: _bf_options(bf_options),
_type_info(type_info),
- _pool(),
+ _arena(),
Review Comment:
warning: initializer for member '_arena' is redundant
[readability-redundant-member-init]
```suggestion
,
```
##########
be/test/olap/key_coder_test.cpp:
##########
@@ -22,18 +22,14 @@
#include <limits>
-#include "runtime/mem_pool.h"
#include "util/debug_util.h"
namespace doris {
class KeyCoderTest : public testing::Test {
public:
- KeyCoderTest() : _pool() {}
+ KeyCoderTest() {}
Review Comment:
warning: use '= default' to define a trivial default constructor
[modernize-use-equals-default]
```suggestion
KeyCoderTest() = default;
```
##########
be/test/olap/row_cursor_test.cpp:
##########
@@ -344,31 +343,31 @@
Slice l_char("well");
int32_t l_int = 10;
- left.set_field_content(0, reinterpret_cast<char*>(&l_char),
_mem_pool.get());
- left.set_field_content(1, reinterpret_cast<char*>(&l_int),
_mem_pool.get());
+ left.set_field_content(0, reinterpret_cast<char*>(&l_char), _arena.get());
+ left.set_field_content(1, reinterpret_cast<char*>(&l_int), _arena.get());
RowCursor right_eq;
res = right_eq.init(tablet_schema);
Slice r_char_eq("well");
int32_t r_int_eq = 10;
- right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_mem_pool.get());
- right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_mem_pool.get());
+ right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_arena.get());
+ right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_arena.get());
EXPECT_EQ(compare_row(left, right_eq), 0);
RowCursor right_lt;
res = right_lt.init(tablet_schema);
Slice r_char_lt("well");
int32_t r_int_lt = 11;
- right_lt.set_field_content(0, reinterpret_cast<char*>(&r_char_lt),
_mem_pool.get());
- right_lt.set_field_content(1, reinterpret_cast<char*>(&r_int_lt),
_mem_pool.get());
+ right_lt.set_field_content(0, reinterpret_cast<char*>(&r_char_lt),
_arena.get());
+ right_lt.set_field_content(1, reinterpret_cast<char*>(&r_int_lt),
_arena.get());
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
right_lt.set_field_content(1, reinterpret_cast<char*>(&r_int_lt),
_arena.get());
^
```
##########
be/test/olap/row_cursor_test.cpp:
##########
@@ -259,13 +258,13 @@ void
set_tablet_schema_for_cmp_and_aggregate(TabletSchemaSPtr tablet_schema) {
class TestRowCursor : public testing::Test {
public:
- TestRowCursor() { _mem_pool.reset(new MemPool()); }
+ TestRowCursor() { _arena.reset(new vectorized::Arena()); }
virtual void SetUp() {}
virtual void TearDown() {}
- std::unique_ptr<MemPool> _mem_pool;
+ std::unique_ptr<Arena> _arena;
Review Comment:
warning: unknown type name 'Arena'; did you mean 'vectorized::Arena'?
[clang-diagnostic-error]
```suggestion
std::unique_ptr<vectorized::Arena> _arena;
```
**be/src/vec/aggregate_functions/aggregate_function.h:34:**
'vectorized::Arena' declared here
```cpp
class Arena;
^
```
##########
be/test/olap/row_cursor_test.cpp:
##########
@@ -344,31 +343,31 @@
Slice l_char("well");
int32_t l_int = 10;
- left.set_field_content(0, reinterpret_cast<char*>(&l_char),
_mem_pool.get());
- left.set_field_content(1, reinterpret_cast<char*>(&l_int),
_mem_pool.get());
+ left.set_field_content(0, reinterpret_cast<char*>(&l_char), _arena.get());
+ left.set_field_content(1, reinterpret_cast<char*>(&l_int), _arena.get());
RowCursor right_eq;
res = right_eq.init(tablet_schema);
Slice r_char_eq("well");
int32_t r_int_eq = 10;
- right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_mem_pool.get());
- right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_mem_pool.get());
+ right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_arena.get());
+ right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_arena.get());
EXPECT_EQ(compare_row(left, right_eq), 0);
RowCursor right_lt;
res = right_lt.init(tablet_schema);
Slice r_char_lt("well");
int32_t r_int_lt = 11;
- right_lt.set_field_content(0, reinterpret_cast<char*>(&r_char_lt),
_mem_pool.get());
- right_lt.set_field_content(1, reinterpret_cast<char*>(&r_int_lt),
_mem_pool.get());
+ right_lt.set_field_content(0, reinterpret_cast<char*>(&r_char_lt),
_arena.get());
+ right_lt.set_field_content(1, reinterpret_cast<char*>(&r_int_lt),
_arena.get());
EXPECT_LT(compare_row(left, right_lt), 0);
Review Comment:
warning: use of undeclared identifier 'compare_row' [clang-diagnostic-error]
```cpp
EXPECT_LT(compare_row(left, right_lt), 0);
^
```
##########
be/test/olap/row_cursor_test.cpp:
##########
@@ -344,31 +343,31 @@
Slice l_char("well");
int32_t l_int = 10;
- left.set_field_content(0, reinterpret_cast<char*>(&l_char),
_mem_pool.get());
- left.set_field_content(1, reinterpret_cast<char*>(&l_int),
_mem_pool.get());
+ left.set_field_content(0, reinterpret_cast<char*>(&l_char), _arena.get());
+ left.set_field_content(1, reinterpret_cast<char*>(&l_int), _arena.get());
RowCursor right_eq;
res = right_eq.init(tablet_schema);
Slice r_char_eq("well");
int32_t r_int_eq = 10;
- right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_mem_pool.get());
- right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_mem_pool.get());
+ right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_arena.get());
+ right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_arena.get());
EXPECT_EQ(compare_row(left, right_eq), 0);
RowCursor right_lt;
res = right_lt.init(tablet_schema);
Slice r_char_lt("well");
int32_t r_int_lt = 11;
- right_lt.set_field_content(0, reinterpret_cast<char*>(&r_char_lt),
_mem_pool.get());
- right_lt.set_field_content(1, reinterpret_cast<char*>(&r_int_lt),
_mem_pool.get());
+ right_lt.set_field_content(0, reinterpret_cast<char*>(&r_char_lt),
_arena.get());
+ right_lt.set_field_content(1, reinterpret_cast<char*>(&r_int_lt),
_arena.get());
EXPECT_LT(compare_row(left, right_lt), 0);
RowCursor right_gt;
res = right_gt.init(tablet_schema);
Slice r_char_gt("good");
int32_t r_int_gt = 10;
- right_gt.set_field_content(0, reinterpret_cast<char*>(&r_char_gt),
_mem_pool.get());
- right_gt.set_field_content(1, reinterpret_cast<char*>(&r_int_gt),
_mem_pool.get());
+ right_gt.set_field_content(0, reinterpret_cast<char*>(&r_char_gt),
_arena.get());
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
right_gt.set_field_content(0, reinterpret_cast<char*>(&r_char_gt),
_arena.get());
^
```
##########
be/test/olap/row_cursor_test.cpp:
##########
@@ -344,31 +343,31 @@
Slice l_char("well");
int32_t l_int = 10;
- left.set_field_content(0, reinterpret_cast<char*>(&l_char),
_mem_pool.get());
- left.set_field_content(1, reinterpret_cast<char*>(&l_int),
_mem_pool.get());
+ left.set_field_content(0, reinterpret_cast<char*>(&l_char), _arena.get());
+ left.set_field_content(1, reinterpret_cast<char*>(&l_int), _arena.get());
RowCursor right_eq;
res = right_eq.init(tablet_schema);
Slice r_char_eq("well");
int32_t r_int_eq = 10;
- right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_mem_pool.get());
- right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_mem_pool.get());
+ right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_arena.get());
+ right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_arena.get());
EXPECT_EQ(compare_row(left, right_eq), 0);
RowCursor right_lt;
res = right_lt.init(tablet_schema);
Slice r_char_lt("well");
int32_t r_int_lt = 11;
- right_lt.set_field_content(0, reinterpret_cast<char*>(&r_char_lt),
_mem_pool.get());
- right_lt.set_field_content(1, reinterpret_cast<char*>(&r_int_lt),
_mem_pool.get());
+ right_lt.set_field_content(0, reinterpret_cast<char*>(&r_char_lt),
_arena.get());
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
right_lt.set_field_content(0, reinterpret_cast<char*>(&r_char_lt),
_arena.get());
^
```
##########
be/test/olap/row_cursor_test.cpp:
##########
@@ -344,31 +343,31 @@
Slice l_char("well");
int32_t l_int = 10;
- left.set_field_content(0, reinterpret_cast<char*>(&l_char),
_mem_pool.get());
- left.set_field_content(1, reinterpret_cast<char*>(&l_int),
_mem_pool.get());
+ left.set_field_content(0, reinterpret_cast<char*>(&l_char), _arena.get());
+ left.set_field_content(1, reinterpret_cast<char*>(&l_int), _arena.get());
RowCursor right_eq;
res = right_eq.init(tablet_schema);
Slice r_char_eq("well");
int32_t r_int_eq = 10;
- right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_mem_pool.get());
- right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_mem_pool.get());
+ right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_arena.get());
+ right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_arena.get());
EXPECT_EQ(compare_row(left, right_eq), 0);
RowCursor right_lt;
res = right_lt.init(tablet_schema);
Slice r_char_lt("well");
int32_t r_int_lt = 11;
- right_lt.set_field_content(0, reinterpret_cast<char*>(&r_char_lt),
_mem_pool.get());
- right_lt.set_field_content(1, reinterpret_cast<char*>(&r_int_lt),
_mem_pool.get());
+ right_lt.set_field_content(0, reinterpret_cast<char*>(&r_char_lt),
_arena.get());
+ right_lt.set_field_content(1, reinterpret_cast<char*>(&r_int_lt),
_arena.get());
EXPECT_LT(compare_row(left, right_lt), 0);
RowCursor right_gt;
res = right_gt.init(tablet_schema);
Slice r_char_gt("good");
int32_t r_int_gt = 10;
- right_gt.set_field_content(0, reinterpret_cast<char*>(&r_char_gt),
_mem_pool.get());
- right_gt.set_field_content(1, reinterpret_cast<char*>(&r_int_gt),
_mem_pool.get());
+ right_gt.set_field_content(0, reinterpret_cast<char*>(&r_char_gt),
_arena.get());
+ right_gt.set_field_content(1, reinterpret_cast<char*>(&r_int_gt),
_arena.get());
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
right_gt.set_field_content(1, reinterpret_cast<char*>(&r_int_gt),
_arena.get());
^
```
##########
be/test/olap/row_cursor_test.cpp:
##########
@@ -344,31 +343,31 @@
Slice l_char("well");
int32_t l_int = 10;
- left.set_field_content(0, reinterpret_cast<char*>(&l_char),
_mem_pool.get());
- left.set_field_content(1, reinterpret_cast<char*>(&l_int),
_mem_pool.get());
+ left.set_field_content(0, reinterpret_cast<char*>(&l_char), _arena.get());
+ left.set_field_content(1, reinterpret_cast<char*>(&l_int), _arena.get());
RowCursor right_eq;
res = right_eq.init(tablet_schema);
Slice r_char_eq("well");
int32_t r_int_eq = 10;
- right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_mem_pool.get());
- right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_mem_pool.get());
+ right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_arena.get());
+ right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_arena.get());
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_arena.get());
^
```
##########
be/test/olap/rowset/segment_v2/binary_dict_page_test.cpp:
##########
@@ -95,7 +94,7 @@ class BinaryDictPageTest : public testing::Test {
EXPECT_EQ(slices.size(), page_decoder.count());
//check values
- MemPool pool;
+ vectorized::Arena pool;
auto type_info = get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR);
size_t size = slices.size();
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
##########
be/test/olap/rowset/segment_v2/binary_dict_page_test.cpp:
##########
@@ -199,7 +198,7 @@
EXPECT_TRUE(status.ok());
//check values
- MemPool pool;
+ vectorized::Arena pool;
auto type_info = get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR);
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
##########
be/test/olap/rowset/segment_v2/binary_plain_page_test.cpp:
##########
@@ -70,7 +69,7 @@ class BinaryPlainPageTest : public testing::Test {
EXPECT_TRUE(status.ok());
//test1
- MemPool pool;
+ vectorized::Arena pool;
size_t size = 3;
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
##########
be/test/olap/rowset/segment_v2/binary_dict_page_test.cpp:
##########
@@ -199,7 +198,7 @@
EXPECT_TRUE(status.ok());
//check values
- MemPool pool;
+ vectorized::Arena pool;
auto type_info = get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR);
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(1, false, type_info, nullptr, &cvb);
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(1, false, type_info, nullptr, &cvb);
^
```
##########
be/test/olap/row_cursor_test.cpp:
##########
@@ -344,31 +343,31 @@
Slice l_char("well");
int32_t l_int = 10;
- left.set_field_content(0, reinterpret_cast<char*>(&l_char),
_mem_pool.get());
- left.set_field_content(1, reinterpret_cast<char*>(&l_int),
_mem_pool.get());
+ left.set_field_content(0, reinterpret_cast<char*>(&l_char), _arena.get());
+ left.set_field_content(1, reinterpret_cast<char*>(&l_int), _arena.get());
RowCursor right_eq;
res = right_eq.init(tablet_schema);
Slice r_char_eq("well");
int32_t r_int_eq = 10;
- right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_mem_pool.get());
- right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_mem_pool.get());
+ right_eq.set_field_content(0, reinterpret_cast<char*>(&r_char_eq),
_arena.get());
+ right_eq.set_field_content(1, reinterpret_cast<char*>(&r_int_eq),
_arena.get());
EXPECT_EQ(compare_row(left, right_eq), 0);
RowCursor right_lt;
res = right_lt.init(tablet_schema);
Slice r_char_lt("well");
int32_t r_int_lt = 11;
- right_lt.set_field_content(0, reinterpret_cast<char*>(&r_char_lt),
_mem_pool.get());
- right_lt.set_field_content(1, reinterpret_cast<char*>(&r_int_lt),
_mem_pool.get());
+ right_lt.set_field_content(0, reinterpret_cast<char*>(&r_char_lt),
_arena.get());
+ right_lt.set_field_content(1, reinterpret_cast<char*>(&r_int_lt),
_arena.get());
EXPECT_LT(compare_row(left, right_lt), 0);
RowCursor right_gt;
res = right_gt.init(tablet_schema);
Slice r_char_gt("good");
int32_t r_int_gt = 10;
- right_gt.set_field_content(0, reinterpret_cast<char*>(&r_char_gt),
_mem_pool.get());
- right_gt.set_field_content(1, reinterpret_cast<char*>(&r_int_gt),
_mem_pool.get());
+ right_gt.set_field_content(0, reinterpret_cast<char*>(&r_char_gt),
_arena.get());
+ right_gt.set_field_content(1, reinterpret_cast<char*>(&r_int_gt),
_arena.get());
EXPECT_GT(compare_row(left, right_gt), 0);
Review Comment:
warning: use of undeclared identifier 'compare_row' [clang-diagnostic-error]
```cpp
EXPECT_GT(compare_row(left, right_gt), 0);
^
```
##########
be/test/olap/rowset/segment_v2/binary_plain_page_test.cpp:
##########
@@ -70,7 +69,7 @@
EXPECT_TRUE(status.ok());
//test1
- MemPool pool;
+ vectorized::Arena pool;
size_t size = 3;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(size, true,
get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR),
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(size, true,
get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR),
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
