github-actions[bot] commented on code in PR #17820:
URL: https://github.com/apache/doris/pull/17820#discussion_r1138035579
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -395,14 +394,14 @@ TEST_F(SegCompactionTest,
SegCompactionInterleaveWithBig_ooooOOoOooooooooO) {
num_segments = 1;
rows_per_segment = 4096;
for (int i = 0; i < num_segments; ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rows_per_segment; ++rid) {
uint32_t k1 = rid * 100 + i;
uint32_t k2 = i;
uint32_t k3 = rid;
- input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&mem_pool);
- input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&arena);
+ input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&arena);
s = rowset_writer->add_row(input_row);
Review Comment:
warning: no member named 'add_row' in 'doris::RowsetWriter'
[clang-diagnostic-error]
```cpp
s = rowset_writer->add_row(input_row);
^
```
##########
be/test/vec/olap/vertical_compaction_test.cpp:
##########
@@ -205,15 +205,15 @@
uint32_t num_rows = 0;
for (int i = 0; i < rowset_data.size(); ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rowset_data[i].size(); ++rid) {
uint32_t c1 = std::get<0>(rowset_data[i][rid]);
uint32_t c2 = std::get<1>(rowset_data[i][rid]);
- input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&c2),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&c2),
&arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(1, reinterpret_cast<char*>(&c2),
&arena);
^
```
##########
be/test/vec/olap/vertical_compaction_test.cpp:
##########
@@ -205,15 +205,15 @@
uint32_t num_rows = 0;
for (int i = 0; i < rowset_data.size(); ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rowset_data[i].size(); ++rid) {
uint32_t c1 = std::get<0>(rowset_data[i][rid]);
uint32_t c2 = std::get<1>(rowset_data[i][rid]);
- input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&c2),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&c2),
&arena);
if (tablet_schema->keys_type() == UNIQUE_KEYS) {
uint8_t num = 0;
- input_row.set_field_content(2,
reinterpret_cast<char*>(&num), &mem_pool);
+ input_row.set_field_content(2,
reinterpret_cast<char*>(&num), &arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(2,
reinterpret_cast<char*>(&num), &arena);
^
```
##########
be/test/vec/olap/vertical_compaction_test.cpp:
##########
@@ -205,15 +205,15 @@
uint32_t num_rows = 0;
for (int i = 0; i < rowset_data.size(); ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rowset_data[i].size(); ++rid) {
uint32_t c1 = std::get<0>(rowset_data[i][rid]);
uint32_t c2 = std::get<1>(rowset_data[i][rid]);
- input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&c2),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&c2),
&arena);
if (tablet_schema->keys_type() == UNIQUE_KEYS) {
uint8_t num = 0;
- input_row.set_field_content(2,
reinterpret_cast<char*>(&num), &mem_pool);
+ input_row.set_field_content(2,
reinterpret_cast<char*>(&num), &arena);
}
s = rowset_writer->add_row(input_row);
Review Comment:
warning: no member named 'add_row' in 'doris::RowsetWriter'
[clang-diagnostic-error]
```cpp
s = rowset_writer->add_row(input_row);
^
```
##########
be/test/vec/olap/vertical_compaction_test.cpp:
##########
@@ -205,15 +205,15 @@ class VerticalCompactionTest : public ::testing::Test {
uint32_t num_rows = 0;
for (int i = 0; i < rowset_data.size(); ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rowset_data[i].size(); ++rid) {
uint32_t c1 = std::get<0>(rowset_data[i][rid]);
uint32_t c2 = std::get<1>(rowset_data[i][rid]);
- input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&c2),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(0, reinterpret_cast<char*>(&c1),
&arena);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
