github-actions[bot] commented on code in PR #17820:
URL: https://github.com/apache/doris/pull/17820#discussion_r1136898526
##########
be/test/olap/key_coder_test.cpp:
##########
@@ -22,18 +22,14 @@
#include <limits>
-#include "runtime/mem_pool.h"
#include "util/debug_util.h"
namespace doris {
class KeyCoderTest : public testing::Test {
public:
- KeyCoderTest() : _pool() {}
- virtual ~KeyCoderTest() {}
-
-private:
- MemPool _pool;
+ KeyCoderTest() = default;
+ virtual ~KeyCoderTest() = default;
Review Comment:
warning: prefer using 'override' or (rarely) 'final' instead of 'virtual'
[modernize-use-override]
```suggestion
~KeyCoderTest() override = default;
```
##########
be/test/olap/rowset/segment_v2/rle_page_test.cpp:
##########
@@ -37,7 +36,7 @@ class RlePageTest : public testing::Test {
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
##########
be/test/olap/rowset/segment_v2/rle_page_test.cpp:
##########
@@ -37,7 +36,7 @@
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(1, true, get_scalar_type_info(type),
nullptr, &cvb);
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(1, true, get_scalar_type_info(type),
nullptr, &cvb);
^
```
##########
be/test/olap/rowset/segment_v2/rle_page_test.cpp:
##########
@@ -37,7 +36,7 @@
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(1, true, get_scalar_type_info(type),
nullptr, &cvb);
ColumnBlock block(cvb.get(), &pool);
Review Comment:
warning: unknown type name 'ColumnBlock' [clang-diagnostic-error]
```cpp
ColumnBlock block(cvb.get(), &pool);
^
```
##########
be/test/olap/rowset/segment_v2/rle_page_test.cpp:
##########
@@ -74,7 +73,7 @@
EXPECT_EQ(0, rle_page_decoder.current_index());
EXPECT_EQ(size, rle_page_decoder.count());
- MemPool pool;
+ vectorized::Arena pool;
Review Comment:
warning: variable has incomplete type 'vectorized::Arena'
[clang-diagnostic-error]
```cpp
vectorized::Arena pool;
^
```
**be/src/vec/columns/column.h:60:** forward declaration of
'doris::vectorized::Arena'
```cpp
class Arena;
^
```
##########
be/test/olap/rowset/segment_v2/rle_page_test.cpp:
##########
@@ -37,7 +36,7 @@
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(1, true, get_scalar_type_info(type),
nullptr, &cvb);
Review Comment:
warning: use of undeclared identifier 'get_scalar_type_info'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(1, true, get_scalar_type_info(type),
nullptr, &cvb);
^
```
##########
be/test/olap/rowset/segment_v2/rle_page_test.cpp:
##########
@@ -74,7 +73,7 @@
EXPECT_EQ(0, rle_page_decoder.current_index());
EXPECT_EQ(size, rle_page_decoder.count());
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
##########
be/test/olap/rowset/segment_v2/rle_page_test.cpp:
##########
@@ -74,7 +73,7 @@
EXPECT_EQ(0, rle_page_decoder.current_index());
EXPECT_EQ(size, rle_page_decoder.count());
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(size, true, get_scalar_type_info(Type),
nullptr, &cvb);
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(size, true, get_scalar_type_info(Type),
nullptr, &cvb);
^
```
##########
be/test/olap/rowset/segment_v2/rle_page_test.cpp:
##########
@@ -74,7 +73,7 @@
EXPECT_EQ(0, rle_page_decoder.current_index());
EXPECT_EQ(size, rle_page_decoder.count());
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(size, true, get_scalar_type_info(Type),
nullptr, &cvb);
Review Comment:
warning: use of undeclared identifier 'get_scalar_type_info'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(size, true, get_scalar_type_info(Type),
nullptr, &cvb);
^
```
##########
be/test/olap/rowset/segment_v2/rle_page_test.cpp:
##########
@@ -74,7 +73,7 @@
EXPECT_EQ(0, rle_page_decoder.current_index());
EXPECT_EQ(size, rle_page_decoder.count());
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(size, true, get_scalar_type_info(Type),
nullptr, &cvb);
ColumnBlock block(cvb.get(), &pool);
Review Comment:
warning: unknown type name 'ColumnBlock' [clang-diagnostic-error]
```cpp
ColumnBlock block(cvb.get(), &pool);
^
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -251,14 +250,14 @@ TEST_F(SegCompactionTest, SegCompactionThenRead) {
// k2 := k1 * 10
// k3 := rid
for (int i = 0; i < num_segments; ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rows_per_segment; ++rid) {
uint32_t k1 = rid * 100 + i;
uint32_t k2 = i;
uint32_t k3 = rid;
- input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&mem_pool);
- input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
^
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -361,14 +360,14 @@
int num_segments = 4;
uint32_t rows_per_segment = 4096;
for (int i = 0; i < num_segments; ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rows_per_segment; ++rid) {
uint32_t k1 = rid * 100 + i;
uint32_t k2 = i;
uint32_t k3 = rid;
- input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&mem_pool);
- input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&arena);
+ input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&arena);
^
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -361,14 +360,14 @@
int num_segments = 4;
uint32_t rows_per_segment = 4096;
for (int i = 0; i < num_segments; ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rows_per_segment; ++rid) {
uint32_t k1 = rid * 100 + i;
uint32_t k2 = i;
uint32_t k3 = rid;
- input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&mem_pool);
- input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&arena);
^
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -251,14 +250,14 @@
// k2 := k1 * 10
// k3 := rid
for (int i = 0; i < num_segments; ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rows_per_segment; ++rid) {
uint32_t k1 = rid * 100 + i;
uint32_t k2 = i;
uint32_t k3 = rid;
- input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&mem_pool);
- input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&arena);
^
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -251,14 +250,14 @@
// k2 := k1 * 10
// k3 := rid
for (int i = 0; i < num_segments; ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rows_per_segment; ++rid) {
uint32_t k1 = rid * 100 + i;
uint32_t k2 = i;
uint32_t k3 = rid;
- input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&mem_pool);
- input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&arena);
+ input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&arena);
s = rowset_writer->add_row(input_row);
Review Comment:
warning: no member named 'add_row' in 'doris::RowsetWriter'
[clang-diagnostic-error]
```cpp
s = rowset_writer->add_row(input_row);
^
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -251,14 +250,14 @@
// k2 := k1 * 10
// k3 := rid
for (int i = 0; i < num_segments; ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rows_per_segment; ++rid) {
uint32_t k1 = rid * 100 + i;
uint32_t k2 = i;
uint32_t k3 = rid;
- input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&mem_pool);
- input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&arena);
+ input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&arena);
^
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -361,14 +360,14 @@
int num_segments = 4;
uint32_t rows_per_segment = 4096;
for (int i = 0; i < num_segments; ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rows_per_segment; ++rid) {
uint32_t k1 = rid * 100 + i;
uint32_t k2 = i;
uint32_t k3 = rid;
- input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&mem_pool);
- input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&arena);
+ input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&arena);
s = rowset_writer->add_row(input_row);
Review Comment:
warning: no member named 'add_row' in 'doris::RowsetWriter'
[clang-diagnostic-error]
```cpp
s = rowset_writer->add_row(input_row);
^
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -378,14 +377,14 @@
num_segments = 2;
rows_per_segment = 6400;
for (int i = 0; i < num_segments; ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rows_per_segment; ++rid) {
uint32_t k1 = rid * 100 + i;
uint32_t k2 = i;
uint32_t k3 = rid;
- input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&mem_pool);
- input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
^
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -361,14 +360,14 @@
int num_segments = 4;
uint32_t rows_per_segment = 4096;
for (int i = 0; i < num_segments; ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rows_per_segment; ++rid) {
uint32_t k1 = rid * 100 + i;
uint32_t k2 = i;
uint32_t k3 = rid;
- input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&mem_pool);
- input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
^
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -378,14 +377,14 @@
num_segments = 2;
rows_per_segment = 6400;
for (int i = 0; i < num_segments; ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rows_per_segment; ++rid) {
uint32_t k1 = rid * 100 + i;
uint32_t k2 = i;
uint32_t k3 = rid;
- input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&mem_pool);
- input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&arena);
^
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -378,14 +377,14 @@
num_segments = 2;
rows_per_segment = 6400;
for (int i = 0; i < num_segments; ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rows_per_segment; ++rid) {
uint32_t k1 = rid * 100 + i;
uint32_t k2 = i;
uint32_t k3 = rid;
- input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&mem_pool);
- input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&arena);
+ input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&arena);
s = rowset_writer->add_row(input_row);
Review Comment:
warning: no member named 'add_row' in 'doris::RowsetWriter'
[clang-diagnostic-error]
```cpp
s = rowset_writer->add_row(input_row);
^
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -378,14 +377,14 @@
num_segments = 2;
rows_per_segment = 6400;
for (int i = 0; i < num_segments; ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rows_per_segment; ++rid) {
uint32_t k1 = rid * 100 + i;
uint32_t k2 = i;
uint32_t k3 = rid;
- input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&mem_pool);
- input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&arena);
+ input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&arena);
^
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -395,14 +394,14 @@
num_segments = 1;
rows_per_segment = 4096;
for (int i = 0; i < num_segments; ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rows_per_segment; ++rid) {
uint32_t k1 = rid * 100 + i;
uint32_t k2 = i;
uint32_t k3 = rid;
- input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&mem_pool);
- input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&arena);
^
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -395,14 +394,14 @@
num_segments = 1;
rows_per_segment = 4096;
for (int i = 0; i < num_segments; ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rows_per_segment; ++rid) {
uint32_t k1 = rid * 100 + i;
uint32_t k2 = i;
uint32_t k3 = rid;
- input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&mem_pool);
- input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
^
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -395,14 +394,14 @@
num_segments = 1;
rows_per_segment = 4096;
for (int i = 0; i < num_segments; ++i) {
- MemPool mem_pool;
+ vectorized::Arena arena;
for (int rid = 0; rid < rows_per_segment; ++rid) {
uint32_t k1 = rid * 100 + i;
uint32_t k2 = i;
uint32_t k3 = rid;
- input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&mem_pool);
- input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&mem_pool);
- input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&mem_pool);
+ input_row.set_field_content(0, reinterpret_cast<char*>(&k1),
&arena);
+ input_row.set_field_content(1, reinterpret_cast<char*>(&k2),
&arena);
+ input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&arena);
Review Comment:
warning: no member named 'set_field_content' in 'doris::RowCursor'
[clang-diagnostic-error]
```cpp
input_row.set_field_content(2, reinterpret_cast<char*>(&k3),
&arena);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
