github-actions[bot] commented on code in PR #17704:
URL: https://github.com/apache/doris/pull/17704#discussion_r1156942024
##########
be/src/service/internal_service.cpp:
##########
@@ -556,6 +561,53 @@ void
PInternalServiceImpl::tablet_fetch_data(google::protobuf::RpcController* co
}
}
+void
PInternalServiceImpl::get_column_ids_by_tablet_ids(google::protobuf::RpcController*
controller,
+ const
PFetchColIdsRequest* request,
+ PFetchColIdsResponse*
response,
+
google::protobuf::Closure* done) {
+ brpc::ClosureGuard guard(done);
+ TabletManager* tablet_mgr = StorageEngine::instance()->tablet_manager();
+ const auto& params = request->params();
+ for (const auto& param : params) {
+ int64_t index_id = param.indexid();
+ auto tablet_ids = param.tablet_ids();
+ std::set<std::vector<TabletColumn>> filter_set;
+ for (const int64_t tablet_id : tablet_ids) {
+ TabletSharedPtr tablet = tablet_mgr->get_tablet(tablet_id);
+ if (tablet == nullptr) {
+ std::stringstream ss;
+ ss << "cannot get tablet by id:" << tablet_id;
+ LOG(WARNING) ss.str();
Review Comment:
warning: expected ';' after expression [clang-diagnostic-error]
```suggestion
LOG(WARNING); ss.str();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
