github-actions[bot] commented on code in PR #17704:
URL: https://github.com/apache/doris/pull/17704#discussion_r1157161780
##########
be/src/service/internal_service.cpp:
##########
@@ -556,6 +563,57 @@ void
PInternalServiceImpl::tablet_fetch_data(google::protobuf::RpcController* co
}
}
+void
PInternalServiceImpl::get_column_ids_by_tablet_ids(google::protobuf::RpcController*
controller,
+ const
PFetchColIdsRequest* request,
+ PFetchColIdsResponse*
response,
+
google::protobuf::Closure* done) {
+ brpc::ClosureGuard guard(done);
+ TabletManager* tablet_mgr = StorageEngine::instance()->tablet_manager();
+ const auto& params = request->params();
+ for (const auto& param : params) {
+ int64_t index_id = param.indexid();
+ auto tablet_ids = param.tablet_ids();
+ std::unordered_set<std::vector<int32_t>> filter_set;
Review Comment:
warning: call to implicitly-deleted default constructor of
'std::unordered_set<std::vector<int32_t>>' (aka 'unordered_set<vector<int>>')
[clang-diagnostic-error]
```cpp
std::unordered_set<std::vector<int32_t>> filter_set;
^
```
**/usr/include/c++/11/bits/unordered_set.h:134:** explicitly defaulted
function was implicitly deleted here
```cpp
unordered_set() = default;
^
```
**/usr/include/c++/11/bits/unordered_set.h:99:** default constructor of
'unordered_set<std::vector<int>>' is implicitly deleted because field '_M_h'
has a deleted default constructor
```cpp
_Hashtable _M_h;
^
```
**/usr/include/c++/11/bits/hashtable.h:527:** explicitly defaulted function
was implicitly deleted here
```cpp
_Hashtable() = default;
^
```
**/usr/include/c++/11/bits/hashtable.h:180:** default constructor of
'_Hashtable<std::vector<int>, std::vector<int>,
std::allocator<std::vector<int>>, std::__detail::_Identity,
std::equal_to<std::vector<int>>, std::hash<std::vector<int>>,
std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash,
std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true,
true, true>>' is implicitly deleted because base class
'__detail::_Hashtable_base<vector<int>, vector<int>, _Identity,
equal_to<vector<int>>, hash<vector<int>>, _Mod_range_hashing,
_Default_ranged_hash, _Hashtable_traits<true, true, true>>' has a deleted
default constructor
```cpp
: public __detail::_Hashtable_base<_Key, _Value, _ExtractKey, _Equal,
^
```
**/usr/include/c++/11/bits/hashtable_policy.h:1603:** explicitly defaulted
function was implicitly deleted here
```cpp
_Hashtable_base() = default;
^
```
**/usr/include/c++/11/bits/hashtable_policy.h:1561:** default constructor of
'_Hashtable_base<std::vector<int>, std::vector<int>, std::__detail::_Identity,
std::equal_to<std::vector<int>>, std::hash<std::vector<int>>,
std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash,
std::__detail::_Hashtable_traits<true, true, true>>' is implicitly deleted
because base class '_Hash_code_base<std::vector<int>, std::vector<int>,
std::__detail::_Identity, std::hash<std::vector<int>>,
std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash,
_Hashtable_traits<true, true, true>::__hash_cached::value>' has a deleted
default constructor
```cpp
: public _Hash_code_base<_Key, _Value, _ExtractKey, _Hash, _RangeHash,
^
```
**/usr/include/c++/11/bits/hashtable_policy.h:1209:** explicitly defaulted
function was implicitly deleted here
```cpp
_Hash_code_base() = default;
^
```
**/usr/include/c++/11/bits/hashtable_policy.h:1188:** default constructor of
'_Hash_code_base<std::vector<int>, std::vector<int>, std::__detail::_Identity,
std::hash<std::vector<int>>, std::__detail::_Mod_range_hashing,
std::__detail::_Default_ranged_hash, true>' is implicitly deleted because base
class '_Hashtable_ebo_helper<1, std::hash<std::vector<int>>>' has a deleted
destructor
```cpp
: private _Hashtable_ebo_helper<1, _Hash>
^
```
**/usr/include/c++/11/bits/hashtable_policy.h:1124:** destructor of
'_Hashtable_ebo_helper<1, std::hash<std::vector<int>>, true>' is implicitly
deleted because base class 'std::hash<std::vector<int>>' has a deleted
destructor
```cpp
: private _Tp
^
```
**/usr/include/c++/11/bits/functional_hash.h:101:** destructor of
'hash<std::vector<int>>' is implicitly deleted because base class
'__hash_enum<std::vector<int>>' has an inaccessible destructor
```cpp
struct hash : __hash_enum<_Tp>
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]