github-actions[bot] commented on code in PR #17704:
URL: https://github.com/apache/doris/pull/17704#discussion_r1159419529
##########
be/src/service/internal_service.cpp:
##########
@@ -556,6 +563,72 @@ void
PInternalServiceImpl::tablet_fetch_data(google::protobuf::RpcController* co
}
}
+void
PInternalServiceImpl::get_column_ids_by_tablet_ids(google::protobuf::RpcController*
controller,
+ const
PFetchColIdsRequest* request,
Review Comment:
warning: pointer parameter 'response' can be pointer to const
[readability-non-const-parameter]
```suggestion
const int* request,
const int* response,
```
##########
be/src/service/internal_service.cpp:
##########
@@ -556,6 +563,72 @@ void
PInternalServiceImpl::tablet_fetch_data(google::protobuf::RpcController* co
}
}
+void
PInternalServiceImpl::get_column_ids_by_tablet_ids(google::protobuf::RpcController*
controller,
+ const
PFetchColIdsRequest* request,
+ PFetchColIdsResponse*
response,
+
google::protobuf::Closure* done) {
+ bool ret = _light_work_pool.try_offer([this, controller, request,
response, done]() {
Review Comment:
warning: cannot initialize a parameter of type 'const
doris::PFetchColIdsRequest *' with an lvalue of type 'const int *const'
[clang-diagnostic-error]
```cpp
_get_column_ids_by_tablet_ids(controller, request, response, done);
^
```
**be/src/service/internal_service.h:196:** passing argument to parameter
'request' here
```cpp
const PFetchColIdsRequest* request,
^
```
##########
be/src/service/internal_service.cpp:
##########
@@ -556,6 +563,72 @@ void
PInternalServiceImpl::tablet_fetch_data(google::protobuf::RpcController* co
}
}
+void
PInternalServiceImpl::get_column_ids_by_tablet_ids(google::protobuf::RpcController*
controller,
+ const
PFetchColIdsRequest* request,
+ PFetchColIdsResponse*
response,
+
google::protobuf::Closure* done) {
+ bool ret = _light_work_pool.try_offer([this, controller, request,
response, done]() {
+ _get_column_ids_by_tablet_ids(controller, request, response, done);
+ });
+ if (!ret) {
+ LOG(WARNING) << "fail to offer request to the work pool";
+ brpc::ClosureGuard closure_guard(done);
+ response->mutable_status()->set_status_code(TStatusCode::CANCELLED);
Review Comment:
warning: member reference base type 'int' is not a structure or union
[clang-diagnostic-error]
```cpp
response->mutable_status()->add_error_msgs("fail to offer request to
the work pool");
^
```
##########
be/src/service/internal_service.cpp:
##########
@@ -556,6 +563,72 @@ void
PInternalServiceImpl::tablet_fetch_data(google::protobuf::RpcController* co
}
}
+void
PInternalServiceImpl::get_column_ids_by_tablet_ids(google::protobuf::RpcController*
controller,
+ const
PFetchColIdsRequest* request,
+ PFetchColIdsResponse*
response,
+
google::protobuf::Closure* done) {
+ bool ret = _light_work_pool.try_offer([this, controller, request,
response, done]() {
+ _get_column_ids_by_tablet_ids(controller, request, response, done);
+ });
+ if (!ret) {
+ LOG(WARNING) << "fail to offer request to the work pool";
+ brpc::ClosureGuard closure_guard(done);
Review Comment:
warning: member reference base type 'int' is not a structure or union
[clang-diagnostic-error]
```cpp
response->mutable_status()->set_status_code(TStatusCode::CANCELLED);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
