gianm commented on a change in pull request #5957: Renamed
GenericColumnSerializer to ColumnSerializer; 'Generic Column' -> 'Numeric
Column'; Fixed a few resource leaks in processing; Fixed a bug in
SingleStringInputDimensionSelector; misc refinements
URL: https://github.com/apache/incubator-druid/pull/5957#discussion_r206791391
##########
File path:
processing/src/main/java/io/druid/segment/virtual/SingleStringInputDimensionSelector.java
##########
@@ -139,7 +139,7 @@ public String lookupName(final int id)
@Override
public boolean nameLookupPossibleInAdvance()
{
- return true;
+ return selector.nameLookupPossibleInAdvance();
Review comment:
This is not a bug, since the constructor verifies that
`selector.nameLookupPossibleInAdvance()` returns true. (Otherwise, the
optimization this class is trying to do is pointless.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
