gianm commented on a change in pull request #5957: Renamed
GenericColumnSerializer to ColumnSerializer; 'Generic Column' -> 'Numeric
Column'; Fixed a few resource leaks in processing; Fixed a bug in
SingleStringInputDimensionSelector; misc refinements
URL: https://github.com/apache/incubator-druid/pull/5957#discussion_r206791574
##########
File path:
processing/src/main/java/io/druid/segment/virtual/SingleStringInputDimensionSelector.java
##########
@@ -153,7 +153,7 @@ public IdLookup idLookup()
@Override
public Object getObject()
{
- return defaultGetObject();
+ return lookupName(getRow().get(0));
Review comment:
I'm not sure this will work for empty rows in multi-value dimensions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
