gianm commented on a change in pull request #5957: Renamed GenericColumnSerializer to ColumnSerializer; 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; Fixed a bug in SingleStringInputDimensionSelector; misc refinements URL: https://github.com/apache/incubator-druid/pull/5957#discussion_r207609525
########## File path: benchmarks/src/main/java/io/druid/benchmark/package-info.java ########## @@ -17,17 +17,7 @@ * under the License. */ -package io.druid.segment; +@EverythingIsNonnullByDefault +package io.druid.benchmark; -import io.druid.guice.annotations.ExtensionPoint; -import io.druid.segment.serde.Serializer; - -import java.io.IOException; - -@ExtensionPoint -public interface GenericColumnSerializer extends Serializer Review comment: IMO it is painful for users to have to make small adjustments for non-functionality-affecting changes each time they upgrade to a new major Druid release. So I think it would be friendlier to do a 'big bang' and make any desired non-functionality-affecting, yet still backwards incompatible, changes like this all in one major release. Probably the one immediately prior to 1.0. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
