nishantmonu51 commented on a change in pull request #5957: Renamed 'Generic
Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; Fixed a
bug in SingleStringInputDimensionSelector; misc refinements
URL: https://github.com/apache/incubator-druid/pull/5957#discussion_r208027976
##########
File path:
processing/src/main/java/io/druid/query/aggregation/AggregatorUtil.java
##########
@@ -198,11 +200,11 @@ public boolean isNull()
throw new IllegalArgumentException("Must have a valid, non-null fieldName
or expression");
}
- public static BaseLongColumnValueSelector
makeColumnValueSelectorWithLongDefault(
+ static BaseLongColumnValueSelector makeColumnValueSelectorWithLongDefault(
final ColumnSelectorFactory metricFactory,
final ExprMacroTable macroTable,
- final String fieldName,
- final String fieldExpression,
+ @Nullable final String fieldName,
+ @Nullable final String fieldExpression,
Review comment:
Add a comment that only one of fieldName or fieldExpression can be null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
