nishantmonu51 commented on a change in pull request #5957: Renamed 'Generic
Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; Fixed a
bug in SingleStringInputDimensionSelector; misc refinements
URL: https://github.com/apache/incubator-druid/pull/5957#discussion_r213655561
##########
File path: processing/src/main/java/io/druid/segment/StorageAdapter.java
##########
@@ -39,12 +39,8 @@
Iterable<String> getAvailableMetrics();
/**
- * Returns the number of distinct values for the given dimension column
- * For dimensions of unknown cardinality, e.g. __time this currently returns
- * Integer.MAX_VALUE
- *
- * @param column
- * @return
+ * Returns the number of distinct values for the given column if known, or
{@link Integer#MAX_VALUE} is unknown or
Review comment:
typo "is unknown" -> "if unknown"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
