nishantmonu51 commented on a change in pull request #5957: Renamed 'Generic
Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; Fixed a
bug in SingleStringInputDimensionSelector; misc refinements
URL: https://github.com/apache/incubator-druid/pull/5957#discussion_r208031155
##########
File path:
processing/src/main/java/io/druid/query/groupby/GroupByQueryEngine.java
##########
@@ -329,14 +329,12 @@ public RowIterator(GroupByQuery query, final Cursor
cursor, ByteBuffer metricsBu
}
final DimensionSelector selector =
cursor.getColumnSelectorFactory().makeDimensionSelector(dimSpec);
- if (selector != null) {
- if (selector.getValueCardinality() ==
DimensionSelector.CARDINALITY_UNKNOWN) {
- throw new UnsupportedOperationException(
- "GroupBy v1 does not support dimension selectors with unknown
cardinality.");
- }
- dimensions.add(selector);
- dimNames.add(dimSpec.getOutputName());
+ if (selector.getValueCardinality() ==
DimensionSelector.CARDINALITY_UNKNOWN) {
+ throw new UnsupportedOperationException(
+ "GroupBy v1 does not support dimension selectors with unknown
cardinality.");
}
+ dimensions.add(selector);
Review comment:
Note to self: reviewed till here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
