jihoonson commented on a change in pull request #6162: Add maven.exec.xxx.skip
option for exec-maven-plugin
URL: https://github.com/apache/incubator-druid/pull/6162#discussion_r219359360
##########
File path: distribution/pom.xml
##########
@@ -46,142 +46,107 @@
<druid.distribution.pulldeps.opts>--clean</druid.distribution.pulldeps.opts>
</properties>
- <build>
- <plugins>
- <plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>exec-maven-plugin</artifactId>
- <executions>
- <execution>
- <id>pull-deps</id>
- <phase>package</phase>
- <goals>
- <goal>exec</goal>
- </goals>
- <configuration>
- <executable>java</executable>
- <arguments>
- <argument>-classpath</argument>
- <classpath/>
-
<argument>-Ddruid.extensions.loadList=[]</argument>
-
<argument>-Ddruid.extensions.directory=${project.build.directory}/extensions</argument>
- <argument>
-
-Ddruid.extensions.hadoopDependenciesDir=${project.build.directory}/hadoop-dependencies
- </argument>
- <argument>org.apache.druid.cli.Main</argument>
- <argument>tools</argument>
- <argument>pull-deps</argument>
- <argument>--clean</argument>
- <argument>--defaultVersion</argument>
- <argument>${project.parent.version}</argument>
- <argument>-l</argument>
-
<argument>${settings.localRepository}</argument>
- <argument>-h</argument>
-
<argument>org.apache.hadoop:hadoop-client:${hadoop.compile.version}</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:druid-avro-extensions</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:druid-datasketches</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:druid-hdfs-storage</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:druid-histogram</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:druid-kafka-eight</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:druid-kafka-extraction-namespace</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:druid-kafka-indexing-service</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:druid-lookups-cached-global</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:druid-lookups-cached-single</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:druid-protobuf-extensions</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:mysql-metadata-storage</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:postgresql-metadata-storage</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:druid-kerberos</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:druid-s3-extensions</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:druid-stats</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:druid-examples</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:simple-client-sslcontext</argument>
- <argument>-c</argument>
-
<argument>org.apache.druid.extensions:druid-basic-security</argument>
-
<argument>${druid.distribution.pulldeps.opts}</argument>
- </arguments>
- </configuration>
- </execution>
- <execution>
- <id>mysql-tarball</id>
- <phase>package</phase>
- <goals>
- <goal>exec</goal>
- </goals>
- <configuration>
- <executable>tar</executable>
- <arguments>
- <argument>-C</argument>
-
<argument>${project.build.directory}/extensions</argument>
- <argument>-czvf</argument>
- <argument>
-
${project.build.directory}/mysql-metadata-storage-${project.parent.version}.tar.gz
- </argument>
- <argument>mysql-metadata-storage</argument>
- </arguments>
- </configuration>
- </execution>
- </executions>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-assembly-plugin</artifactId>
- <executions>
- <execution>
- <id>distro-assembly</id>
- <phase>package</phase>
- <goals>
- <goal>single</goal>
- </goals>
- <configuration>
-
<finalName>${project.parent.artifactId}-${project.parent.version}</finalName>
- <tarLongFileMode>posix</tarLongFileMode>
- <descriptors>
-
<descriptor>src/assembly/assembly.xml</descriptor>
- </descriptors>
- </configuration>
- </execution>
- </executions>
- </plugin>
- <plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>license-maven-plugin</artifactId>
- <executions>
- <execution>
- <id>download-licenses</id>
- <goals>
- <goal>download-licenses</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
<profiles>
<profile>
- <id>bundle-contrib-exts</id>
+ <id>dist</id>
+ <activation>
+ <activeByDefault>false</activeByDefault>
+ <property>
+ <name>tar</name>
+ </property>
+ </activation>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<executions>
+ <execution>
+ <id>pull-deps</id>
+ <phase>package</phase>
+ <goals>
+ <goal>exec</goal>
+ </goals>
+ <configuration>
+ <executable>java</executable>
+ <arguments>
+ <argument>-classpath</argument>
+ <classpath/>
+
<argument>-Ddruid.extensions.loadList=[]</argument>
+
<argument>-Ddruid.extensions.directory=${project.build.directory}/extensions
+ </argument>
+ <argument>
+
-Ddruid.extensions.hadoopDependenciesDir=${project.build.directory}/hadoop-dependencies
+ </argument>
+ <argument>io.druid.cli.Main</argument>
Review comment:
We have changed all package names from `io.druid` to `org.apache.druid`.
Please fix this.
Same for other places below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
