clintropolis commented on a change in pull request #6129: Add support for
'maxTotalRows' to incremental publishing kafka indexing task and appenderator
based realtime task
URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r211027082
##########
File path:
server/src/main/java/io/druid/segment/realtime/appenderator/AppenderatorImpl.java
##########
@@ -1118,16 +1094,18 @@ public String apply(SegmentIdentifier input)
final boolean removeOnDiskData
)
{
+ if (sink.isWritable()) {
Review comment:
For one, it seemed to be more legit to check that to match the `we only
count active sinks` comment which implies writable to me. Additionally, since
there are a couple of paths to decrementing the `totalRows` counter, I wanted
to make sure I never double decremented it (it's other decrement is also tied
to finishWriting).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
