clintropolis commented on a change in pull request #6129: Add support for
'maxTotalRows' to incremental publishing kafka indexing task and appenderator
based realtime task
URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r211039685
##########
File path:
server/src/main/java/io/druid/segment/realtime/appenderator/AppenderatorConfig.java
##########
@@ -30,12 +30,48 @@
{
boolean isReportParseExceptions();
+ /**
+ * Maximum number of rows in memory before persisting to local storage
+ *
+ * @return
+ */
int getMaxRowsInMemory();
+ /**
+ * Maximum number of bytes (estimated) to store in memory before persisting
to local storage
+ *
+ * @return
+ */
long getMaxBytesInMemory();
+
int getMaxPendingPersists();
+ /**
+ * Maximum number of rows in a single segment before pushing to deep storage
+ *
+ * @return
+ */
+ default int getMaxRowsPerSegment()
+ {
+ return Integer.MAX_VALUE;
+ }
+
+ /**
+ * Maximum number of rows across all segments before pushing to deep storage
+ *
+ * @return
+ */
+ @Nullable
+ default Long getMaxTotalRows()
Review comment:
It's nullable to be consistent with [how `IndexTask` was using
it](https://github.com/apache/incubator-druid/blob/master/indexing-service/src/main/java/io/druid/indexing/common/task/IndexTask.java#L1106).
I don't have strong opinions about `null` vs `Long.MAX_VALUE`, I'll rework
where this is used to get rid of nullable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
