gaodayue commented on a change in pull request #6402: Thread-safe QueryMetrics URL: https://github.com/apache/incubator-druid/pull/6402#discussion_r221677644
########## File path: processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java ########## @@ -289,12 +320,26 @@ public void identity(String identity) } @Override - public void emit(ServiceEmitter emitter) + public void emit(final ServiceEmitter emitter) Review comment: What's the benefits of maintaining QueryMetrics's owner thread? I think one benefit of making QueryMetrics thread-safe is that users can create it in one thread and use it in another thread without explicitly transferring ownership. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
