gaodayue commented on a change in pull request #6402: Thread-safe QueryMetrics
URL: https://github.com/apache/incubator-druid/pull/6402#discussion_r223288053
 
 

 ##########
 File path: 
processing/src/main/java/org/apache/druid/query/GroupByMergedQueryRunner.java
 ##########
 @@ -114,10 +113,10 @@ public Void call()
                           {
                             try {
                               if (bySegment) {
-                                input.run(threadSafeQueryPlus, responseContext)
+                                input.run(queryPlus.withQueryMetricsCopied(), 
responseContext)
 
 Review comment:
   OK, I'll revert changes relating to QueryPlus class. However, since 
QueryMetrics is now a thread-safe class, the old name 
withoutThreadUnsafeState() is out of date. I will use withoutQueryMetrics() 
instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to