a2l007 commented on a change in pull request #6419: Add ability to specify dbcp
properties file
URL: https://github.com/apache/incubator-druid/pull/6419#discussion_r223387543
##########
File path:
server/src/main/java/org/apache/druid/metadata/SQLMetadataConnector.java
##########
@@ -636,7 +638,21 @@ protected BasicDataSource getDatasource()
{
MetadataStorageConnectorConfig connectorConfig = getConfig();
- BasicDataSource dataSource = new BasicDataSource();
+ BasicDataSource dataSource = null;
+
+ try {
+ Properties dbcpProperties = connectorConfig.getProperties();
Review comment:
Presently, users can give a
[PasswordProvider](http://druid.io/docs/latest/operations/password-provider.html)
object when they specify the `druid.metadata.storage.connector.password`
property. It would be helpful if the users have the flexibility to provide the
`PasswordProvider` object within the dbcp config file instead of the plaintext
password.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
