a2l007 commented on a change in pull request #6419: Add ability to specify dbcp
properties file
URL: https://github.com/apache/incubator-druid/pull/6419#discussion_r223034617
##########
File path:
common/src/main/java/org/apache/druid/metadata/MetadataStorageConnectorConfig.java
##########
@@ -86,9 +112,20 @@ public String toString()
", connectURI='" + getConnectURI() + '\'' +
", user='" + user + '\'' +
", passwordProvider=" + passwordProvider +
+ ", dbcpPropertiesFile=" + dbcpPropertiesFile +
'}';
}
+ String getDbcpPropertiesFile()
+ {
+ return dbcpPropertiesFile;
+ }
+
+ void setDbcpPropertiesFile(String dbcpPropertiesFile)
Review comment:
Can we avoid this setter method by creating a Properties object within the
`TestDerbyConnector` class and this object could be created off of a temporary
properties file within the test class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
