a2l007 commented on a change in pull request #6419: Add ability to specify dbcp
properties file
URL: https://github.com/apache/incubator-druid/pull/6419#discussion_r223379257
##########
File path:
common/src/main/java/org/apache/druid/metadata/MetadataStorageConnectorConfig.java
##########
@@ -78,6 +88,22 @@ public String getPassword()
return passwordProvider == null ? null : passwordProvider.getPassword();
}
+ public Properties getProperties() throws IOException
+ {
+ if (dbcpPropertiesFile == null) {
+ return null;
+ } else {
+ //no reason to save properties file as it is only used on startup
+ File propertiesFile = new File(dbcpPropertiesFile);
Review comment:
Can we use `File.createTempFile` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
