AlexanderSaydakov commented on a change in pull request #6381: datsketches
extension updated to use the latest sketches-core-0.12.0
URL: https://github.com/apache/incubator-druid/pull/6381#discussion_r224642513
##########
File path:
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/theta/SketchAggregator.java
##########
@@ -42,7 +42,7 @@ public SketchAggregator(BaseObjectColumnValueSelector
selector, int size)
private void initUnion()
{
- union = new SynchronizedUnion((Union)
SetOperation.builder().setNominalEntries(size).build(Family.UNION));
+ union = (Union)
SetOperation.builder().setNominalEntries(size).build(Family.UNION);
Review comment:
> It probably still makes sense to keep SynchronizedUnion class around
Given the new API, it is impossible to make SynchronizedUnion a subclass of
Union as it was before. But making it just a wrapper breaks a lot of other
code, so it was way easier to get rid of it altogether.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
