AlexanderSaydakov commented on a change in pull request #6381: datsketches
extension updated to use the latest sketches-core-0.12.0
URL: https://github.com/apache/incubator-druid/pull/6381#discussion_r224641516
##########
File path:
extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchAggregationTest.java
##########
@@ -200,6 +200,7 @@ public void ingestingSketchesTwoValues() throws Exception
" \"name\": \"union\",",
" \"operation\": \"UNION\",",
" \"nominalEntries\": 1024,",
+ " \"numberOfValues\": 2,",
Review comment:
This was a mistake in the test. The number of values in the union and
incoming sketches must match, which was not enforced before. Correct code
should not be affected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
