leventov commented on a change in pull request #6699: release mmap immediately 
after merge indexes
URL: https://github.com/apache/incubator-druid/pull/6699#discussion_r239528746
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/segment/IndexMerger.java
 ##########
 @@ -189,6 +189,15 @@ File persist(
       @Nullable SegmentWriteOutMediumFactory segmentWriteOutMediumFactory
   ) throws IOException;
 
+  File mergeSegmentFiles(
 
 Review comment:
   Please add javadoc with the rationale for this method, and the difference 
from the most closely related one, `mergeQueryableIndex()`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to