leventov commented on a change in pull request #6699: release mmap immediately
after merge indexes
URL: https://github.com/apache/incubator-druid/pull/6699#discussion_r239860085
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorImpl.java
##########
@@ -716,8 +717,20 @@ private DataSegment mergeAndPush(final SegmentIdentifier
identifier, final Sink
closer.register(segmentAndCloseable.rhs);
}
- mergedFile = indexMerger.mergeQueryableIndex(
- indexes,
Review comment:
If this is about avoiding refreshing some memory mapped files in memory
(although I don't see the mechanism how it helps either), at very least the
surrounding `try {}` block should be refactored, because currently it couples
the creation of the `indexes` list and `mergeSegmentFiles()` for no apparent
reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
