jihoonson commented on a change in pull request #6828: Kill Hadoop MR task on
kill of Hadoop ingestion task
URL: https://github.com/apache/incubator-druid/pull/6828#discussion_r248164030
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/SingleTaskBackgroundRunner.java
##########
@@ -182,13 +182,14 @@ public void stop()
final long elapsed;
boolean error = false;
- if (taskConfig.isRestoreTasksOnRestart() && task.canRestore()) {
- // Attempt graceful shutdown.
- graceful = true;
- log.info("Starting graceful shutdown of task[%s].", task.getId());
+ // stopGracefully for resource cleaning, independent of the fact whether
the task is restorable or not
+ // Attempt graceful shutdown.
+ graceful = true;
Review comment:
`graceful` is always true. Please remove it and set `true` for metric like
below.
```java
final ServiceMetricEvent.Builder metricBuilder = ServiceMetricEvent
.builder()
.setDimension("task", task.getId())
.setDimension("dataSource", task.getDataSource())
.setDimension("graceful", "true") // for backward compatibility
.setDimension("error", String.valueOf(error));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
