jihoonson commented on a change in pull request #6828: Kill Hadoop MR task on
kill of Hadoop ingestion task
URL: https://github.com/apache/incubator-druid/pull/6828#discussion_r248162260
##########
File path:
indexing-hadoop/src/main/java/org/apache/druid/indexer/JobHelper.java
##########
@@ -372,7 +391,23 @@ public static boolean runSingleJob(Jobby job,
HadoopDruidIndexerConfig config)
public static boolean runJobs(List<Jobby> jobs, HadoopDruidIndexerConfig
config)
{
boolean succeeded = true;
+ ObjectMapper objectMapper = new ObjectMapper();
+
for (Jobby job : jobs) {
+ String hadoopJobId = job.submitAndGetHadoopJobId();
+ String hadoopJobIdFileName = config.getHadoopJobIdFileName();
+
+ if (hadoopJobIdFileName != null) {
+ try {
+ objectMapper.writeValue(new OutputStreamWriter(
Review comment:
Please extract the duplicated lines to another method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
