jihoonson commented on a change in pull request #6828: Kill Hadoop MR task on
kill of Hadoop ingestion task
URL: https://github.com/apache/incubator-druid/pull/6828#discussion_r248163789
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/Task.java
##########
@@ -163,8 +163,8 @@ default int getPriority()
boolean canRestore();
/**
- * Asks a task to arrange for its "run" method to exit promptly. This method
will only be called if
- * {@link #canRestore()} returns true. Tasks that take too long to stop
gracefully will be terminated with
+ * Asks a task to arrange for its "run" method to exit promptly. This method
will be called, whether
Review comment:
Let's just remove `This method will be called, whether {@link #canRestore()}
returns true/false.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
