jihoonson commented on a change in pull request #6828: Kill Hadoop MR task on
kill of Hadoop ingestion task
URL: https://github.com/apache/incubator-druid/pull/6828#discussion_r248165482
##########
File path: indexing-service/pom.xml
##########
@@ -90,6 +90,16 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
Review comment:
We really shouldn't add hadoop dependencies to druid core because 1) it's
unnecessary if we don't use hadoop and 2) it might cause some errors because of
the version mismatch when we use a different version of Hadoop.
Please move them to `indexing-hadoop`. The version must not be specified and
the scope should be `provided`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
