jihoonson commented on a change in pull request #6828: Kill Hadoop MR task on
kill of Hadoop ingestion task
URL: https://github.com/apache/incubator-druid/pull/6828#discussion_r248464438
##########
File path: core/src/main/java/org/apache/druid/indexer/Jobby.java
##########
@@ -30,6 +30,17 @@
{
boolean run();
+ /**
+ *
+ * @return A string represtenting the jobId of the actual MR job.
+ * Run method is now divided into two parts. The first one being
submitAndGetHadoopJobId which just submits the job and returns the job ID
+ * Run then monitors this job for completion
+ */
+ default String submitAndGetHadoopJobId()
Review comment:
Thanks, but I think it's too specific for an implementation of
`DeterminePartitionsJob` which can't handle any other custom `Jobby`
implementations running two or more Hadoop jobs.
I think maybe it's not a good idea to add `submitAndGetHadoopJobId` to
`Jobby` because a single `Jobby` can run 0, 1, or more Hadoop jobs. How about
removing `submitAndGetHadoopJobId` from `Jobby` but adding `writeHadoopJobId`
to `JobHelper`? Every `Jobby` running one or more Hadoop jobs should use this
method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
