jihoonson commented on a change in pull request #6828: Kill Hadoop MR task on
kill of Hadoop ingestion task
URL: https://github.com/apache/incubator-druid/pull/6828#discussion_r248162713
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopIndexTask.java
##########
@@ -218,10 +223,20 @@ public String getClasspathPrefix()
return classpathPrefix;
}
+ public String getHadoopJobIdFileName()
+ {
+ final String HADOOP_JOB_ID_FILENAME = "mapReduceJobId.json";
+ StringBuilder fileName = new
StringBuilder(taskConfig.getTaskDir(getId()).toString());
+ fileName.append("/");
+ fileName.append(HADOOP_JOB_ID_FILENAME);
+ return fileName.toString();
Review comment:
Should be `return new File(taskConfig.getTaskDir(getId()),
HADOOP_JOB_ID_FILENAME).getAbsolutePath();`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
